jgilfelt / chuck

An in-app HTTP inspector for Android OkHttp clients
Apache License 2.0
4.68k stars 452 forks source link

Optimize string allocation of getShareText function #19

Closed jsonchi closed 7 years ago

jsonchi commented 7 years ago

Reduce string allocation

jgilfelt commented 7 years ago

Thanks, but a modern Java compiler will make most of these optimisations in the byte code, and this method isn't called on a performance critical path anyway. All this does is make the code less readable in my opinion.