search

jgilfelt / chuck

An in-app HTTP inspector for Android OkHttp clients
Apache License 2.0
4.68k stars 452 forks source link

Lower minSdk requirement to API 11 #20

Closed mannodermaus closed 7 years ago

mannodermaus commented 7 years ago

The only occurence of an API available only from Android 4.1 onward in this project comes from the reference of android.util.LongSparseArray inside NotificationHelper. Since you're pulling in & using support-v4 anyway, it is a very low-maintenance effort to reduce the minSdk requirement down to API 11 by using android.support.v4.util.LongSparseArray.

Also, I disabled the lint check which trips over Okio's reference to Java NIO.

(I haven't checked if it could go down even lower than that, but I guess we need to draw the line somewhere.)

jgilfelt commented 7 years ago

Thanks, unfortunately I don't consider it a low-maintenance effort to support a project on these ancient versions, whether the code will run on them or not. I've drawn the line at 16.

mannodermaus commented 7 years ago

Ok, fair enough. Thanks for the review!