jgilfelt / chuck

An in-app HTTP inspector for Android OkHttp clients
Apache License 2.0
4.68k stars 452 forks source link

Filter certain sensitive keywords on release build #62

Open TonyTangAndroid opened 6 years ago

TonyTangAndroid commented 6 years ago

This is such an awesome library that I could not express how much I was excited to introduce this feature to our Quality Assurance Engineer. It brings us to a new level to distinguish issues from Client issue or Server issue. Currently, we only enable it in debug build. However, we are seriously thinking about enabling it in release build, which will bring certain security concerns as we are not allowed to save sensitive information like access token or password. I reckon we could add certain key words to filter before the data is to cached when we build the intercepter. I am not sure this is a proper feature request for such library but I would like to give it a try and integrate such feature into my forked library. If this feature is aligning with your thoughts, I would be happy to send a pull request once it is done. Let me know how you think of it.