jgitver / jgitver-maven-plugin

maven core extension to automatically define versions using jgitver & git tags
https://jgitver.github.io/
Other
159 stars 42 forks source link

Add Guice module to bind JGitverConfiguration to JGitverConfiguration #140

Closed marcobjorge closed 3 years ago

marcobjorge commented 4 years ago

Without a Guice binding looking up the org.apache.maven.project.ProjectBuilder on other plugins will throw an exception trying to load {@link fr.brouillard.oss.jgitver.JGitverConfiguration} (only started on maven 3.6.3).

1) No implementation for fr.brouillard.oss.jgitver.JGitverConfiguration was bound.
  while locating fr.brouillard.oss.jgitver.JGitverModelProcessor
  at ClassRealm[plugin>fr.brouillard.oss:jgitver-maven-plugin:1.5.1, parent: sun.misc.Launcher$AppClassLoader@5c647e05] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
  while locating org.apache.maven.model.building.ModelProcessor
  at org.eclipse.sisu.wire.LocatorWiring
  while locating org.apache.maven.model.building.ModelProcessor
    for field at org.apache.maven.model.building.DefaultModelBuilder.modelProcessor(Unknown Source)
  while locating com.feedzai.commons.maven.license.builder.ScopeFilterModelBuilder
McFoggy commented 3 years ago

closed with adb34bb