search

jglamine / calvinwebprint

A friendlier interface to the printing system at Calvin College.
https://calvinwebprint.com
MIT License
6 stars 7 forks source link

added font-awesome CSS so we can use their icons #17

Closed tylervz closed 9 years ago

jglamine commented 9 years ago

Did you test that adding icons actually works? It looks like this might reference some files in ../fonts/

tylervz commented 9 years ago

I have not yet tested it. I'll do that right now. Actually I'll do that in a few hours, because math colloquium is going to start soon.

On Thu, Apr 16, 2015 at 3:11 PM, James Lamine notifications@github.com wrote:

Did you test that adding icons actually works? It looks like this might reference some files in ../fonts/

— Reply to this email directly or view it on GitHub https://github.com/jglamine/calvinwebprint/pull/17#issuecomment-93818095 .

tylervz commented 9 years ago

It did require files in ../fonts/. Now it works. What do you think of this size spinners? loading-spinners

jglamine commented 9 years ago

That size is great, I'd just change the placement so they are aligned with the headings. On Apr 16, 2015 5:38 PM, "Tyler VanZanten" notifications@github.com wrote:

It did require files in ../fonts/. Now it works. What do you think of this size spinners? [image: loading-spinners] https://cloud.githubusercontent.com/assets/8753239/7191931/5ed3a26a-e45f-11e4-92a5-9bde7d72596f.PNG

— Reply to this email directly or view it on GitHub https://github.com/jglamine/calvinwebprint/pull/17#issuecomment-93845725 .

tylervz commented 9 years ago

Alright, I updated the PR. It's ready to be merged. Fixes #13.