search

jglamine / calvinwebprint

A friendlier interface to the printing system at Calvin College.
https://calvinwebprint.com
MIT License
6 stars 7 forks source link

Added an about page. #20

Closed tylervz closed 9 years ago

tylervz commented 9 years ago

Fixes #16 and #8.

jglamine commented 9 years ago

Right now this isn't linked to from anywhere, right? The plan is for someone to make this into a jinja template during the hackathon so we can make it live.

tylervz commented 9 years ago

I added a link to it at the bottom of the home page. But waiting a couple weeks for it to go live would be fine with me.

jglamine commented 9 years ago

I don't see anything wrong with adding it now.

jglamine commented 9 years ago

Combine this with the help page, and delete anything from the help page which isn't needed. Then make this a jinja template and put it in a new templates directory.

jglamine commented 9 years ago

See my other project if you need help with templates: https://github.com/jglamine/phage/tree/master/webphamerator/app

tylervz commented 9 years ago

I updated the PR. But it isn't ready yet to be merged.

tylervz commented 9 years ago

I updated the PR and it's ready for code review.

jglamine commented 9 years ago

I accidentally commented on the diff instead of the PR, but apart from my few small comments, everything looks good.

tylervz commented 9 years ago

Alright, I updated the PR.

jglamine commented 9 years ago

Good work. I made one comment. Change it if you want to, otherwise you can merge it now.