search

jglamine / calvinwebprint

A friendlier interface to the printing system at Calvin College.
https://calvinwebprint.com
MIT License
6 stars 7 forks source link

Print jobs can now be deleted form the queue. Fixes #12. #45

Closed tylervz closed 9 years ago

tylervz commented 9 years ago

The feature we've all been waiting for. (Besides drag & drop).

tylervz commented 9 years ago

@jglamine take a look at this when you can. I'll fix the errors I spotted once you look through it.

jglamine commented 9 years ago

I'm done with code review.

tylervz5 commented 9 years ago

@jglamine I updated this pull request. After several hours trying to figure out how to use Ember to update the DOM instead of jQuery, I gave up and went back to my original code. I also tried updating Ember but it required rewriting much of app.js.

jglamine commented 9 years ago

Looks good to me. I think I have some comments on here which you never addressed, but you don't have to.

Yeah, using ember was a mistake.

Go ahead and merge this if you think it's ready.

PS: I am currently at ACL.