jglick / sezpoz

SezPoz: lightweight, annotation-based service loader
29 stars 11 forks source link

[JENKINS-4409] Disable URLClassLoader cache before opening stream #9

Closed Vlatombe closed 9 years ago

Vlatombe commented 9 years ago

This commit implements a workaround for https://bugs.openjdk.java.net/browse/JDK-8013099

The previous behaviour was causing retention of file handles, resulting in temp folder leaks when executing Jenkins test cases.

buildhive commented 9 years ago

Jesse Glick » sezpoz #18 SUCCESS This pull request looks good (what's this?)

jglick commented 9 years ago

This seems problematic. For the normal case that JARs are not changing “beneath your feet”, it will result in worse performance, since the JAR might need to be closed and reopened for each lookup. And it probably only matters on Windows in practice.

I think it is less controversial to just disable caches globally during tests on Windows, leaving Linux and production systems untouched.