jgliss / geonum

Python toolbox for 3D geo-numerical calculations
GNU General Public License v3.0
6 stars 3 forks source link

Add pyproject.toml #24

Closed magnusuMET closed 10 months ago

magnusuMET commented 1 year ago
jgliss commented 10 months ago

@magnusuMET thanks for this PR. Could you describe in a little more detail why you suggest this change and what benefits it brings over using setup.py?

Also, will it affect the conda release recipe: https://github.com/jgliss/geonum-feedstock/blob/master/recipe/meta.yaml?

Cheers to MET :-)

jgliss commented 10 months ago

Please also note #25 which should fix the pipeline once it's merged :)

magnusuMET commented 10 months ago

setup.py does not allowing specifying dependencies, meaning pip can not resolve and install them for us. That means downstream users has to keep track of the dependencies of this package and manually install them (add them to their pyproject etc., requirements). Having this functionality means a pip install is as simple as the way one can install through conda.

I do not think the move to pyproject.toml should affect the conda recipie

codecov-commenter commented 10 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (efdc3cd) 90.47% compared to head (db763a8) 90.30%.

Files Patch % Lines
geonum/_init_helpers.py 66.66% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main-dev #24 +/- ## ============================================ - Coverage 90.47% 90.30% -0.18% ============================================ Files 15 15 Lines 1376 1382 +6 ============================================ + Hits 1245 1248 +3 - Misses 131 134 +3 ``` | [Flag](https://app.codecov.io/gh/jgliss/geonum/pull/24/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Gli%C3%9F) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/jgliss/geonum/pull/24/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Gli%C3%9F) | `90.30% <66.66%> (-0.18%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Gli%C3%9F#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jgliss commented 10 months ago

Looks good now, thanks @magnusuMET