Closed magnusuMET closed 10 months ago
@magnusuMET thanks for this PR. Could you describe in a little more detail why you suggest this change and what benefits it brings over using setup.py?
Also, will it affect the conda release recipe: https://github.com/jgliss/geonum-feedstock/blob/master/recipe/meta.yaml?
Cheers to MET :-)
Please also note #25 which should fix the pipeline once it's merged :)
setup.py
does not allowing specifying dependencies, meaning pip
can not resolve and install them for us. That means downstream users has to keep track of the dependencies of this package and manually install them (add them to their pyproject etc., requirements). Having this functionality means a pip install
is as simple as the way one can install through conda.
I do not think the move to pyproject.toml
should affect the conda recipie
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
efdc3cd
) 90.47% compared to head (db763a8
) 90.30%.
Files | Patch % | Lines |
---|---|---|
geonum/_init_helpers.py | 66.66% | 3 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good now, thanks @magnusuMET
pkg_resources
for use by python 3.12 and up