search

jgliss / pyplis

Python toolbox for the analysis of UV SO2 camera data
GNU General Public License v3.0
7 stars 5 forks source link

Move tests from example scripts into test suite #25

Closed jgliss closed 5 years ago

jgliss commented 5 years ago

Currently the example scripts contain high-level tests at the end that ensure that the basic analysis works. These tests should be migrated into the test-suite as testing should ideally not be done within the example scripts (it was a convenient quick solution due to lack of time).

The corresponding tests should / could use pytest.skipif markers (or similar) to make sure they are only run if the pyplis example data is available.

johannjacobsohn commented 5 years ago

I dont think this is necessary if we plan to move to notebooks anyway. With Tox/travis, the scripts are used as high-level integration tests and probably should stay that way.

jgliss commented 5 years ago

Thanks, Johann. I agree that this is not an urgent matter for now and that it can stay the way it is.