search

jgliss / pyplis

Python toolbox for the analysis of UV SO2 camera data
GNU General Public License v3.0
7 stars 5 forks source link

Add scripts and static code analysis #27

Closed johannjacobsohn closed 5 years ago

johannjacobsohn commented 5 years ago

This PR is based on #26. Please review after that PR has been merged, the diff will be much shorter.

./scripts should be run during ci to ensure they are still working and to provide a much wider test based than py.test (9d5f5bf ).

To ensure consistent code quality, flake8 (0530f6b) and pydocstyle (9591729) should also be tested for during integration.

Since we are not using tox I've removed the tox config and placed flake8, pytest and pydocstyle configs into their respective default files (638583c).

I cannot test travis, but I tried to clean the .travis.yml file up a but, specifically to not repeat dependencies that are already defined in pyplis_env.yml

jgliss commented 5 years ago

Indeed, the tests fail:

https://travis-ci.org/jgliss/pyplis/jobs/570262753

I agree that test coverage should be higher for CI, but in my opinion these tests should be within pytest and based on the images in directory pyplis/data/testdata_minimal and should be lightweight.