jgliss / pyplis

Python toolbox for the analysis of UV SO2 camera data
GNU General Public License v3.0
7 stars 5 forks source link

Altitude offset of MeasGeometry not updated from Camera object #41

Open twVolc opened 2 years ago

twVolc commented 2 years ago

When trying to change the altitude offset, which might be important for correct light dilution lines, the offset isn't changed once the camera altitude offset is changed.

It looks like the OrderDict of MeasGeometry._cam has the wrong key: in camera the attribute is "alt_offset" but in the _cam OD it is "altitude_offset". When unpacking in MeasGeometry.update_cam_specs() the key is therefore ignored and not updated. Very small issue and quick fix - I should be able to update this and create a pull request soon. If that is indeed the problem.

jgliss commented 2 years ago

Sounds very reasonable, feel free to create a PR! Cheers!