search

jgliss / pyplis

Python toolbox for the analysis of UV SO2 camera data
GNU General Public License v3.0
7 stars 5 forks source link

fixed getting volcano info from online source #44

Closed ubdbra001 closed 1 year ago

ubdbra001 commented 1 year ago

Hi @jgliss,

I'm working on a project that has pyplis as a dependency, and noticed that the getting volcano info from the NOAA was broken by the site change. So, I've updated the get_source_info_online function to use the NOAA API and added a function to ensure the dictionary returned matches the pyplis naming conventions.

I'v tried to keep the output as close to the original as possible to prevent any breakages, but it would be good if you could take a look.

Dan

jgliss commented 1 year ago

@ubdbra001 thanks for fixing this, I will try to look into it asap, however, do you think you could add some tests in the test suite for the updated code (e.g. fetch info from one or 2 example volcanoes)?

jgliss commented 1 year ago

Fixes #35

ubdbra001 commented 1 year ago

No problem! Sure, will do this week

ubdbra001 commented 1 year ago

Hi @jgliss,

Just added and pushed a test for the fix. It covers the main use case, but let me know if you'd like more.

Dan

jgliss commented 1 year ago

Thanks, @ubdbra001 I will check!

jgliss commented 1 year ago

@ubdbra001 it seems like I need to update the CI workflow first (remove unsupported python versions etc) and you will probably need to update your branch against v145dev once I have fixed the workflow. I will ping you once this is done!

jgliss commented 1 year ago

@ubdbra001 I updated the workflow and environments (see #45) in v145dev, could you please update your branch so I can trigger the pipeline once more? Cheers

ubdbra001 commented 1 year ago

@jgliss Done, awaiting workflow approval now