search

jglisson / elmah

Automatically exported from code.google.com/p/elmah
Apache License 2.0
0 stars 0 forks source link

Migrate to Automatic Package Restore #373

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
https://code.google.com/r/jamesdriscoll71-nuget-changes

Purpose of code changes on this branch:

Change the way we do NuGet in line with:
http://blog.davidebbo.com/2014/01/the-right-way-to-restore-nuget-packages.html

When reviewing my code changes, please focus on:

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by jamesdriscoll71 on 12 Oct 2014 at 9:59

GoogleCodeExporter commented 8 years ago 
I've almost merged this. The only issue I'm seeing is that there is a 
discrepency between building from VS and the command line. If you do a fresh 
clone of your repo, build from within VS and run the demo web site, then 
checking out the log page produces the following error:

Unable to load DLL 'SQLite.Interop.dll': The specified module could not be 
found. (Exception from HRESULT: 0x8007007E)

If you take another fresh clone (or clean the existing one with hg purge --all) 
and use build.cmd then the demo site works flawlessly. It seems as if the 
restore from within VS does not honour package restore for Web Site projects.

Could you take a look at this? Thanks!

Original comment by azizatif on 12 Oct 2014 at 10:57

GoogleCodeExporter commented 8 years ago

Original comment by azizatif on 12 Oct 2014 at 10:57

GoogleCodeExporter commented 8 years ago 
I also noticed that NuGet.exe was now being downloaded to tools when going over 
build.cmd but the added file is not being ignored (e.g. shows up in `hg stat 
-S` or when just doing `hg stat` in the tools directory). Perhaps `.hgignore` 
needs updating?

P.S. Don't forget to turn reviewing on on the clone repo.

Original comment by azizatif on 13 Oct 2014 at 6:32

GoogleCodeExporter commented 8 years ago 
Downloading NuGet.exe behind a proxy when building over build.cmd fails with:

C:\ELMAH\nuget\nugetRestore.proj(39,9): error : The remote server returned an 
error: (407) Proxy Authentication Required

Original comment by azizatif on 13 Oct 2014 at 6:35

GoogleCodeExporter commented 8 years ago 
For a potential fix to comment #4, see the following Web Essentials 2013 issue 
that's in the same vien:
https://github.com/madskristensen/WebEssentials2013/issues/1293

Original comment by azizatif on 13 Oct 2014 at 6:46

GoogleCodeExporter commented 8 years ago 
I've merged changes thus far (revision fbc19da53512).
Issue in comment #4 was address by revision 2b868f3d8a7f    .

Original comment by azizatif on 4 Mar 2015 at 8:09

GoogleCodeExporter commented 8 years ago 
Addressed comment #3:
https://code.google.com/p/elmah/source/detail?r=a8485ee5f0050197e44960d525180afa
71504cbd&repo=tools

This concludes the review.

Original comment by azizatif on 4 Mar 2015 at 8:16

GoogleCodeExporter commented 8 years ago 
Problem highlighted in comment #1 still continues to exist and has been 
migrated as issue #384.

Original comment by azizatif on 4 Mar 2015 at 8:33

GoogleCodeExporter commented 8 years ago

Original comment by azizatif on 4 Mar 2015 at 10:49