search

jglobus / JGlobus

jGlobus is a collection of Java client libraries for Globus® Toolkit security, GRAM, and GridFTP.
http://www.globus.org/toolkit/jglobus/
Apache License 2.0
24 stars 44 forks source link

Added gridshib-common and gridshib-saml-tools. #113

Open ysvenkat opened 11 years ago

ysvenkat commented 11 years ago

Documentation will follow in a subsequent commit/pull-request.

bbockelm commented 11 years ago

Hi,

This seems to be a self-contained project, no? Is there any reason this can't live as its separate github project?

Brian

ysvenkat commented 11 years ago

This has a dependency on a couple of Jglobus modules and there weren't going to be any releases of gridshib-saml-tools as a separate project. Hence, Suresh and Jim (cc'd) felt it would be best to bring it into the Jglobus fold for automatic releases with other Jglobus modules and community maintenance...

On 9/16/13 3:32 PM, "Brian Bockelman" notifications@github.com wrote:

Hi, This seems to be a self-contained project, no? Is there any reason this can't live as its separate github project? Brian ‹ Reply to this email directly or view it on GitHub https://github.com/jglobus/JGlobus/pull/113#issuecomment-24542026.

smarru commented 11 years ago

I echo Venkat's comment. These tools were long associated with Globus tools like the http://gridshib.globus.org/docs/gridshib-saml-tools-0.5.0/readme.html and GRAM Audit records. For instance to submit a GRAM job and feed in the required audit fields (http://www.globus.org/toolkit/docs/5.2/5.2.4/gram5/admin/#idp6576736), the JGlobus client feeds in by decorating the proxy with saml assertions.

However, I can see the concerns of the big PR. Briefly skimming through I see that it should not disrupt or break the core jglobus functionality. Unless there are objections, I can volunteer to merge it and test it through and work with feedback to @ysvenkat .

ellert commented 11 years ago

This pull request adds pre-compiled jars. For me this is a reason to reject it.