add axis support - Githubissues

jglobus / JGlobus

jGlobus is a collection of Java client libraries for Globus® Toolkit security, GRAM, and GridFTP.

http://www.globus.org/toolkit/jglobus/

Apache License 2.0

24 stars 44 forks source link

add axis support #50

Closed kofemann closed 12 years ago

kofemann commented 12 years ago

dCache project still uses axis module from jglobus. This was dropped from jglobus2 and forces us to sill maintain a dependency on old globus libraries. This change brings axis support back.

Tigran.

bbockelm commented 12 years ago

Ah, I was hoping someone would send this pull!

A few questions: 1) You got bit by the crazy mixture of tabs and spaces in pom.xml. Can you make a change there to match the other lines? 2) Can we call the artifact "axis" instead of "jglobus-axis"? That would better match the naming schemes of the other packages. 3) It appears there are a few unit tests included. Do they currently pass?

Thanks.

kofemann commented 12 years ago

Ok, the (1) is fixed. (2) one is tricky as it will have a conflict with apache axis. (3) is a part of original code and passes. I bit messed with rebase, so you have to pull only 87cfaf7789a0d929ea74cb2ada25145a8f83093a.

Thanks, Tigran.

kofemann commented 12 years ago

I have added two another two commits to cleanup some of pom file mess:

external dependencies should be defined in parent pom to provide a single point to all of them and keep track of used versions
compile plugin should be configured in parent pom to provide a single place to specify generated byte code version

bbockelm commented 12 years ago

Ok, one last request before I merge - can you do the rename of axis->axisg?

kofemann commented 12 years ago

ready!