small cleanup in CertificateIOUtil

jglobus / JGlobus

jGlobus is a collection of Java client libraries for Globus® Toolkit security, GRAM, and GridFTP.

http://www.globus.org/toolkit/jglobus/

Apache License 2.0

24 stars 44 forks source link

small cleanup in CertificateIOUtil #54

Closed kofemann closed 11 years ago

kofemann commented 11 years ago

The CertificateIOUtil.nameHash() accepts Principal as an argument and later on tries to detect argument's type by choosing between X500Principal or X509Name. Nevertheless X509Name doesn't implements Principal interface and never can be passes. This cleanup introduces introduces two new methods nameHash(X509Name subjectDN) and nameHash(X500Principal subjectDN) as well as uses X509Certificate.getSubjectX500Principal() instead of X509Certificate.getSubjectDN() as javadoc suggests.

Tigran.

bbockelm commented 11 years ago

Hi Tigran,

This pull is for master. Would you like it in any other branch (other options are v2.0.x and v2.0.5)?

Brian

kofemann commented 11 years ago

Hi Brian,

there is a follow-up patch for 2.0.5. We observe strange behavior with dCache.ORG CA. Currently we are testing that new fixes did not brake old behavior. as long as new changes are not committed there is no reason to merge this change into 2.0.5

Thanks, Tigran.