search

jglobus / JGlobus

jGlobus is a collection of Java client libraries for Globus® Toolkit security, GRAM, and GridFTP.
http://www.globus.org/toolkit/jglobus/
Apache License 2.0
24 stars 44 forks source link

Code duplication #77

Closed ellert closed 11 years ago

ellert commented 11 years ago

Some classes are available in two copies in the source tree. They are therefore present in more than one of the installed jars, which is bad.

The first duplication is: gss/src/main/java/org/globus/net/ gram/src/main/java/org/globus/net/

The version in gss has one extra source file not present in the version in gram. Other than that the code only differs due to different version of the license headers. I suggest removing the version in gram

The second duplication is: io/src/main/java/org/globus/io/gass/ gram/src/main/java/org/globus/io/gass/

These directories are identical except one has an extra package.html file not present in the other. Since these are org.globus.io classes keeping the version in io would make sense. But some of the tests in the gram directory uses gass, so these tests whould have to be moved to io in that case.

ellert commented 11 years ago

Resolved by merging pull request #79.