search

jglovier / resume-template

:page_facing_up::briefcase::tophat: A simple Jekyll + GitHub Pages powered resume template.
http://resume-template.joelglovier.com
MIT License
1.85k stars 1.75k forks source link

Update icon-links.html #10

Closed bvolpato closed 8 years ago

bvolpato commented 8 years ago

Of course we want people going to our social media/relates pages, but it doesn't mean that we want people to leave our resume. So this PR is to open the links in a new tab.

jglovier commented 8 years ago

@brunocvcunha thanks for the PR, but I think this should be a matter of personal preference which can be customized in your fork. I can see the rationale, but my target="_blank" is a usability anti-pattern, and generally very annoying behavior to most users, which is why I'd like to keep it to self by default.

bvolpato commented 8 years ago

Thanks for the response @jglovier.

I understand your point and sometimes I'm also annoyed with target="_blank", but in this context for me it makes sense because the main focus is not the social media - these things are related information. If someone go to your Twitter they can be easily distracted (other subjects, their own notifications, etc) and lose focus from what really brought them to that address: you and your resume.

jglovier commented 8 years ago

@brunocvcunha totally understand, and I don't disagree. But I think it's a matter of preference, so it should be something you can customize in your fork. I could see an argument for making it something you can set in the config though, so if you want to create a PR to make it easily changeable via config I'd be open to that.