search

jglovier / resume-template

:page_facing_up::briefcase::tophat: A simple Jekyll + GitHub Pages powered resume template.
http://resume-template.joelglovier.com
MIT License
1.87k stars 1.76k forks source link

Automatic generation of PDF #102

Open bjornamr opened 3 years ago

bjornamr commented 3 years ago

Hi

So the basic Idea I have in my fork of your code is that every time I update my resume, the PDF I have linked on my fork is updated.

I have added two things to the fork to make that happen:

You can take a look at my example on https://bjornamr.github.io/resume-template/

Do you want me to do a new fork and include these changes into a pull request? Maybe update the README.md to explain how to create an access token.

jglovier commented 3 years ago

@bjornamr wow, this is really cool!!

How much control do you have over the typography? I wonder if we can use some custom CSS to style the output for the PDF a little more page friendly?

bjornamr commented 3 years ago

Inserting action.yml file for reference: Action.yml

I am a bit unsure of how much control we have and I am no expert at styling or CSS. I see that puppeteer is what is used behind one of the steps called SetiZ/web_to_pdf_action.

It seems to be based of this repo: https://github.com/fifsky/html-to-pdf-action/pull/1 If you take a look at html to pdf - fifsky it seems like it might be possible to add css and custom fonts.

Would you be able to take a look at the fifsky solution? Maybe it is possible to include some fonts and css to generate better PDF.

bjornamr commented 3 years ago

I have an Idea @jglovier after looking into this a little. From what I understand, to be able to control the PDF, you would have to write special css / sass for printing.

This would make it possible to have full control and give you the ability to control fonts, placement etc.

jglovier commented 3 years ago

Oh nice! Yeah I can def make a custom stylesheet for the print layout.

Not sure when I'll have some free time to work on it, but it's on my radar now. 👍

bjornamr commented 3 years ago

Just wanted to add that I figured out a bug in the action, so I updated it in the fork.

jglovier commented 3 years ago

Awesome! Thanks for the update, and for your patience. :bow: Still on my radar.

alterstep commented 3 years ago

It is going to be added to the upstream project?

bjornamr commented 3 years ago

@jglovier If you could give me some pointers or just some help to start up, I am sure I can help doing some of it. I am not so well versed on front-end development.

readycode15 commented 3 years ago

fff