search

jglovier / resume-template

:page_facing_up::briefcase::tophat: A simple Jekyll + GitHub Pages powered resume template.
http://resume-template.joelglovier.com
MIT License
1.85k stars 1.75k forks source link

More social media links #93

Open julianatfg opened 4 years ago

julianatfg commented 4 years ago

This is not an issue properly, just a question: is there any way to add more social media links to the top menu? I currently have only Github, Twitter and Instagram enabled but I'd like to add like Telegram and WhatsApp, for instance.

I'm kind of a newbie, still learning &c. and I saw that there's no SVG icon for them and I have no idea where to get more.

Btw my forked project is here. Loved the layout!

Thanks!

jglovier commented 4 years ago

Hi @julianatfg! I'm really happy to hear you've found this project useful, and your site looks great. I hope it serves your purposes well.

is there any way to add more social media links to the top menu? I currently have only Github, Twitter and Instagram enabled but I'd like to add like Telegram and WhatsApp, for instance.

You can, but it's a pretty manual process right now. You'd have to find the icons for the services you've mentioned and add them to the code.

I'd be happy to do that, but I don't have much free time to devote to this project right now so I'm not sure how quickly I'll be able to add them.

I'll leave this issue open until I am able to address those.

julianatfg commented 4 years ago

@jglovier Thank you for the reply! I could try adding them and then, if successful, I could do a pull request so it can be merged with the master branch! I've never done it (like I said, GitHub newbie) so I'd be happy to help with the development somehow. I just don't know where to get more of those vector icons. I've found others but they're not in the same style.

julianatfg commented 4 years ago

@jglovier I managed to find more icons! The changes aren't live yet; I've published to another branch as I'm not sure about them yet (and I think that title area is too crowded rn).

But anyway, if I open a pull request to your code, I saw that ALL my modifications are gonna come aboard, I can't choose just the specific files and folders to include in that pull request. Or I'm doing something wrong...

julianatfg commented 4 years ago

My commit to default branch @jglovier

jglovier commented 4 years ago

@julianatfg :wave: hi! I'm sorry for the long radio silence here (I was out of town for a couple weeks, and since returning have not had a chance to review this). Will review and respond soon, just wanted to let you know it's still on my radar. :blush: Thank you for your patience!

julianatfg commented 4 years ago

Hi! No problem at all! Whenever you have some free time. Glad to be of some help!

Anugya12 commented 2 years ago

i want to work on this issue @julianatfg

aflah02 commented 8 months ago

@julianatfg Just curious, where did you get the icons from? I also need some for other services like youtube but haven't been able to find one which matches the other existing icons