jgm / djot.js

JavaScript implementation of djot
MIT License
146 stars 16 forks source link

Fix border display of table header cells #1

Closed waldyrious closed 1 year ago

waldyrious commented 1 year ago

Originally submitted at https://github.com/jgm/djot/pull/177.

The stylesheet had a rule that was probably a typo, since it adds a border to the entire rows (<tr>), which is redundant with the border added to the cells (<td>); and it fails to add a border to <th> elements. So the following table:

| test | foo |
|------|-----|
| bar  | baz |

currently looks like this:

image

With this change (in particular, 3f6ce3c), it will look like this:

image

Note that I also added some cell padding (5927408).

waldyrious commented 1 year ago

@jgm I've moved the changes from https://github.com/jgm/djot/pull/177 to here. This time I made sure to make separate commits for each semantically atomic change, so I'd appreciate it if you merged without squashing the commits. Cheers!

jgm commented 1 year ago

Thanks!