Open lmullen opened 10 years ago
jgm
commented
10 years ago I'm not crazy about making it the default, or about distributing the ace source with gitit (since it's a huge library). But it might make sense to add a config option to use ace. The default could simply be to load ace from the jsdelivr CDN, http://www.jsdelivr.com/#!ace and then gitit wouldn't need to ship ace sources...
Morgul
commented
10 years ago I would love that. Either code mirror or ace are great choices; I write a lot of technical docs in a wiki, so having useful tab support and syntax highlighting are huge wins for me.
lmullen
commented
10 years ago I'll implement this as you suggest, making Ace opt-in through the configuration file and using the CDN, and you can take a look to see whether you like it.
trdlo
commented
9 years ago @lmullen could you provide your hacked code, if the pull request is not on it's way? i am rather lazy figuring it out myself as how to do it, especially when someone else already managed to get it working himself
lmullen
commented
9 years ago Everything you need should be in this gist: https://gist.github.com/lmullen/e2d2d4aabf84220c517a
On Mon, Sep 1, 2014 at 3:17 AM, trdlo notifications@github.com wrote:
@lmullen https://github.com/lmullen could you provide your hacked code, if the pull request is not on it's way? i am rather lazy figuring it out myself as how to do it, especially when someone else already managed to get it working himself
— Reply to this email directly or view it on GitHub https://github.com/jgm/gitit/issues/427#issuecomment-54028151.
I've added the Ace editor to my installation of Gitit to use with Vim mode. Would you be interested in a pull request that added Ace? I've implemented it as a hack with my own idiosyncratic preferences, but I can add it with sane defaults if you wanted to ship it with gitit.