jgm / gitit

A wiki using HAppS, pandoc, and git
GNU General Public License v2.0
2.14k stars 225 forks source link

Username and no javascript #575

Open taruti opened 7 years ago

taruti commented 7 years ago

Currently when javascript is not enabled gitit shows the user as not logged in in the userbox.

E.g. 0) Configure gitit to use http authentication 1) Setup e.g. nginx as proxy 2) Visit gitit and login via http 3) "Login Logout" displayed in userbox 4) Spend lots of time debugging why the authentication information is not passed to gitit 5) Notice that it is just hidden when Javascript is not enabled in the browser

Could a CSS trick be used to get the username when there is no Javascript or at least display something less confusing in the userbox?

jgm commented 7 years ago

Sure, a noscript tag might help here. I'd accept a PR.

+++ Taru Karttunen [Oct 06 16 01:45 ]:

Currently when javascript is not enabled gitit shows the user as not logged in in the userbox.

E.g. 0) Configure gitit to use http authentication 1) Setup e.g. nginx as proxy 2) Visit gitit and login via http 3) "Login Logout" displayed in userbox 4) Spend lots of time debugging why the authentication information is not passed to gitit 5) Notice that it is just hidden when Javascript is not enabled in the browser

Could a CSS trick be used to get the username when there is no Javascript or at least display something less confusing in the userbox?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, [1]view it on GitHub, or [2]mute the thread.

References

  1. https://github.com/jgm/gitit/issues/575
  2. https://github.com/notifications/unsubscribe-auth/AAAL5BbtkNEK8XZZ8CXxD6vlSqonnR9_ks5qxLUwgaJpZM4KPsJs