Add option for disabling registration

jgm / gitit

A wiki using HAppS, pandoc, and git

GNU General Public License v2.0

2.13k stars 225 forks source link

Add option for disabling registration #668

Closed zaxtax closed 3 years ago

zaxtax commented 3 years ago

This adds an option to disable user registration. While I can hack it now with an access question, this feels like a more secure way to do this as it leaves one less endpoint that hackers could potentially exploit.

jgm commented 3 years ago

How about adding the field (with default value false) and a comment documenting it to default.conf in data/?

zaxtax commented 3 years ago

Will do!

zaxtax commented 3 years ago

Thanks for merging so quickly. I just noticed a minor bug in my own commit.

https://github.com/zaxtax/gitit/commit/5b29d6e93feea95ccf8b370844303641690726e2

I pushed a fix on the branch but don't know if I should open a fresh PR for something so small.

jgm commented 3 years ago

Hm, I think you need to create a new PR now that this is merged.