Trivial change to support Lua 5.1/LuaJIT.

jgm / lcmark

Flexible CommonMark converter

BSD 2-Clause "Simplified" License

55 stars 6 forks source link

Trivial change to support Lua 5.1/LuaJIT. #4

Closed Shados closed 5 years ago

Shados commented 5 years ago

Changes

Fixes issue #3.
Avoids polluting the global environment when creating the environment for the loaded filters.
Tests modified to account for slight differences in error messages across Lua versions.

Notes

This passes all your tests on LuaJIT 2.1, Lua 5.1, 5.2, and 5.3. That said, I don't have actual data to test it on at this point, so there may be some issues... but I didn't notice any 5.2+-specific features used aside from _ENV, so I think this should be entirely 5.1 compatible.

jgm commented 5 years ago

I honestly can't remember what lua 5.2+ features I was thinking of when I wrote the other comment, and it has been a long time since I wrote this code! Probably safe to merge this -- thanks!

jgm commented 4 years ago

OK, I think I've updated it successfully now on luarocks.