search

jgm / skylighting

A Haskell syntax highlighting library with tokenizers derived from KDE syntax highlighting descriptions
189 stars 61 forks source link

Add Nim syntax #102

Closed danipozo closed 4 years ago

danipozo commented 4 years ago

Adds Nim XML syntax file from https://github.com/juancarlospaco/NimKate

jgm commented 4 years ago

Is there no nim.xml in the KDE repository? If not, has this been submitted upstream?

danipozo commented 4 years ago

I'm guessing it's this repo. In that case, no, there is no nim.xml there. Is it preferable that I submit this in that repo?

jgm commented 4 years ago

Correct. We can merge it here before it's accepted there, but I like things to be at least submitted, because periodically we resync with the KDE definitions.

jgm commented 4 years ago

Also it would be good to include author and license attributes on the top-level element.

danipozo commented 4 years ago

I have added the author and license to the XML file, and submitted this PR which I hope is noticed at some point. That's the most I can do now about submitting this upstream.

jgm commented 4 years ago

great, thanks.