search

jgm / skylighting

A Haskell syntax highlighting library with tokenizers derived from KDE syntax highlighting descriptions
189 stars 61 forks source link

Added basic Swift support. #128

Closed elland closed 3 years ago

jgm commented 3 years ago

Have you submitted this upstream to KDE?

elland commented 3 years ago

@jgm not yet, the plan was to do it right away, but I went down a rabbit hole trying to build pandoc with my fork of this library today.

We could close this until I get everything sorted out and submit it upstream first.

jgm commented 3 years ago

No problem to leave this open while you do that.

elland commented 3 years ago

@jgm MR completed upstream. 🚀

jgm commented 3 years ago

Great, can you link here to the upstream issue?

elland commented 3 years ago

@jgm I hope I understood you correctly. Here's the links.

https://invent.kde.org/frameworks/syntax-highlighting/-/tree/7f740e4f2052c0d9be3df6c47bb95617257590ab https://invent.kde.org/frameworks/syntax-highlighting/-/issues/11

jgm commented 3 years ago

Thanks!

elland commented 3 years ago

@jgm would it be possible to push the new changes to hackage / pandoc as well?

jgm commented 3 years ago

Eventually they will be.