search

jgm / skylighting

A Haskell syntax highlighting library with tokenizers derived from KDE syntax highlighting descriptions
190 stars 61 forks source link

Add Elm syntax definition #66

Closed harfangk closed 5 years ago

harfangk commented 5 years ago

Signed-off-by: Bonghyun Kim bonghyun.d.kim@gmail.com

This PR adds syntax definition for Elm language, and covers #51 .

jgm commented 5 years ago

Is this syntax definition in the KDE repository? If not, have you submitted it there?

harfangk commented 5 years ago

I've also submitted it there too: https://phabricator.kde.org/D19438

It's my first time submitting it there so I would have to make some adjustments, but it's there. Is there something I can do for the PR to your repository, too?

On Sat, Mar 2, 2019 at 7:52 AM John MacFarlane notifications@github.com wrote:

Is this syntax definition in the KDE repository? If not, have you submitted it there?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jgm/skylighting/pull/66#issuecomment-468838870, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhRKBq4zeXIP7uSzRZgROeRINQAZQndks5vSa8rgaJpZM4bYeRr .

-- Bonghyun Kim Software Developer

jgm commented 5 years ago

Thanks!

dbaynard commented 5 years ago

Does the Skylighting.Syntax.Elm line need adding to the checked-in version of skylighting.cabal, too?

jgm commented 5 years ago

Correct. That is done automatically by make bootstrap, but I hadn't done that yet. Should now be fixed.