jgodson / shopify-script-creator

React app to create Shopify Scripts
https://jgodson.github.io/shopify-script-creator/
GNU General Public License v3.0
163 stars 40 forks source link

Payment gateway renamer #79

Closed mathijsdelva-karo closed 1 year ago

mathijsdelva-karo commented 1 year ago

Hi there,

It seems that the Payment Gateway renaming script does not seem to work anymore. Can you reproduce this?

Reading through various threads on the internet, it seems this may be related to the fact that Shopify has updated its payment API and the way it required external payment providers to adjust their approach. Eg, since a few months, you are required to install actual "apps" as payment methods by using the app store (for example: https://apps.shopify.com/mollie-credit-card).

Do you have any insight in this?

jgodson commented 1 year ago

Hello it's been a while since I worked with any payment gateway renaming so unfortunately I might not be of much help here.

I did check and I was able to rename Credit card as it shows up in checkout and the Script Editor app, however not using the name Credit card. I had to check in the code to see what the name actually was to input that as the name to change (see puts gateway.name below and the 3 results in the Console area). I imagine the name depends on what provider one is using here.

image image

I was not able to rename PayPal, but the API docs do say you can't change any gateways with logos (which PayPal does have). The manual payment method I have can also be renamed by using it's name.

mathijsdelva-karo commented 1 year ago

Oh, i completely missed that small sentence in the documentation. Good eye. I've been in chat with Shopify Plus support for a while now and they never mentioned this, sigh. I let them know about the fact it is in the documentation so i can confirm that is the source of the issue. Meanwhile i'm using a small JS script to adjust the name of my desired payment gateway name.

Thank you so much for taking a look!

jgodson commented 1 year ago

No problem, glad I could help out!