search

jgoerzen / ftphs

FTP client and server library [Haskell]
http://wiki.github.com/jgoerzen/ftphs/
GNU Lesser General Public License v2.1
16 stars 16 forks source link

Make getbinary return ByteString #20

Open Xandaros opened 7 years ago

Xandaros commented 7 years ago

I also removed the unsafeInterleaveIO part because I don't know what it does. Seems to work without it.

If it does something crucial which I'm missing, you'll have to add it yourself, since I don't know how to do that with ByteStrings.

jgoerzen commented 7 years ago

I think the one feedback I would add is to add a new function that returns a ByteString, rather than remove the existing one, such that we don't introduce an API incompatibility.

fizruk commented 5 years ago

I would rather just bump major version. ByteString is the way to go and String arguably should almost never be used 😄