search

jgomezdans / sar_homework

3 stars 4 forks source link

Implementation roughness Oh 2004 #7

Open McWhity opened 4 years ago

McWhity commented 4 years ago

I have no idea how the roughness is implemented in the code. Original the roughness is implemented as a e-funktion of ks. I don't see that anywhere in the code.

jgomezdans commented 4 years ago

There's a discussion of this https://github.com/jgomezdans/sar_homework/blob/master/LMU_new_soil.ipynb.

McWhity commented 4 years ago

There is a discussion about how you want to simplify the soil model but that doesn't change the fact that the roughness part of the Oh2004 model is not coded within the function.

McWhity commented 4 years ago

Please look at the updated notebook https://github.com/McWhity/sar_homework/blob/master_lmu/LMU_new_soil.ipynb . There might be other assumptions due to updated code implementation