search

jgontrum / spacy-api-docker

spaCy REST API, wrapped in a Docker container.
https://hub.docker.com/r/jgontrum/spacyapi/
MIT License
265 stars 99 forks source link

Sentence support #20

Closed NoFishLikeIan closed 5 years ago

NoFishLikeIan commented 5 years ago

Hi @jgontrum, and thank you for this nice repo! It saved my server just today.

I am opening this small pull request because I forked the repo in order to add some sentence splitting support, specular to this method of Doc in Spacy. It is not a big addition and I thought it could be useful to somebody as it was for me.

Of course this is just a preliminary idea, hopefully you can give me some feedback on changes/improvements and or, in case you want to do so, reason for rejecting it and not wanting the feature.

I tried to keep the API as similar as possible to the one in master.

jgontrum commented 5 years ago

Hi @NoFishLikeIan! Thanks a lot for your PR! I'll try to have a look into it this week and come back to you then :)

janschultecom commented 5 years ago

+1 would be great to get this merged :-)

jgontrum commented 5 years ago

Tested it and it works fines :) Thanks again for adding this feature!