first stab at implementing ssl verification option

jgorset / facepy

Facepy makes it really easy to use Facebook's Graph API with Python

MIT License

863 stars 199 forks source link

first stab at implementing ssl verification option #77

Closed tijs closed 11 years ago

tijs commented 11 years ago

I think this will already do the trick. Does it need a separate test you think? I guess you would need a broken SSL implementation that is always available to really test it, seems... difficult.

jgorset commented 11 years ago

Great! I like your implementation. Thanks so much.

We can test this by mocking self.session.request and verify that it receives an argument verify that corresponds to the value of self.verify_ssl_certificate. I don't mind holding off on that, though, but I'll keep the issue open so that someone does add a test eventually.

jgorset commented 11 years ago

… or, I would, if GitHub allowed me to reopen it.

tijs commented 11 years ago

Great thank you too, it's nice to be merged ;)