jgosmann / dmarc-metrics-exporter

Export Prometheus metrics from DMARC reports.
MIT License
42 stars 6 forks source link

Add dmarc-metrics-exporter executable #23

Closed mweinelt closed 2 years ago

mweinelt commented 2 years ago

Wraps the call to app.main() into a callable function that can be wrapped into an executable, allowing installations into the PATH, which makes it more approachable to people who aren't pythonistas.

After this change the exporter can be started using both

codecov-commenter commented 2 years ago

Codecov Report

Merging #23 (3fe401f) into main (3f1a016) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   96.19%   96.20%           
=======================================
  Files          27       27           
  Lines        1577     1580    +3     
=======================================
+ Hits         1517     1520    +3     
  Misses         60       60           
Impacted Files Coverage Δ
dmarc_metrics_exporter/__main__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f1a016...3fe401f. Read the comment docs.

jgosmann commented 2 years ago

Please fix the code formatting (apply black) and import order (apply isort). Also compare with the Development Section of the Readme.

mweinelt commented 2 years ago

Fixed. Thanks for the pointers.