jgosmann commented 2 years ago

The issue mentioned in this comment needs to be fixed too of course. It is not immediately clear to me what the issue is and I would have to investigate it.

JamborJan commented 2 years ago

Thank you for the contribution. There are a few points that I think should be addressed before merging this. Let me know if you want to make the changes or whether I should take over.

Hey @jgosmann , thanks for getting back to me. Let me review your replies and I'll adjust as far as I can. I'm sure you'll have to do the last part by pushing the image to your docker hub account then.

codecov-commenter commented 2 years ago

Codecov Report

Merging #3 (8280f36) into main (08dea99) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   95.19%   95.20%   +0.01%     
==========================================
  Files          21       21              
  Lines         832      835       +3     
==========================================
+ Hits          792      795       +3     
  Misses         40       40

Impacted Files	Coverage Δ
dmarc_metrics_exporter/imap_queue.py	`92.85% <ø> (ø)`
dmarc_metrics_exporter/dmarc_metrics.py	`95.12% <100.00%> (+0.38%)`	:arrow_up:
dmarc_metrics_exporter/tests/test_dmarc_metrics.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08dea99...8280f36. Read the comment docs.

jgosmann / dmarc-metrics-exporter

Suggestion for docker image #3

Codecov Report