search

jgoux / generator-angulpify

Yeoman generator involving AngularJS, Gulp and Browserify
138 stars 21 forks source link

Bundle bootstrap into CSS #15

Closed sodoku closed 9 years ago

sodoku commented 9 years ago

The generator asks me if i want bootstrap and bundles that in the bundle.js, but it does not bundle the css into the bundle.css

jgoux commented 9 years ago

Hi @sodoku , could you be more precise about the issue? Which options did you chose in the terminal ? When you type gulp, do you have any error ? Do you have a bundle.css in your build/ folder ?

sodoku commented 9 years ago

Hi @jgoux, i used JS, HTML and all features toggled on.

Gulp runs fine, but it does not add the bootstrap.min.css file to bundle.css, which i thought it should. Maybe there is another way, which I am not aware of. Maybe it should be added to the index.html.

jgoux commented 9 years ago

I'll investigate this WE. Thanks for the report.

sodoku commented 9 years ago

Thanks for looking at it!

sodoku commented 9 years ago

@jgoux any progress? Can I help somehow?

jgoux commented 9 years ago

Sorry @sodoku I'm quite busy these days. I totally forgot to handle the case when you include bootstrap + choose CSS in the options. I'll try to make a fix as soon as possible. Again, sorry for not being as available as I'd like to be.

sodoku commented 9 years ago

@jgoux no problem. Thanks for building angulpify!

jgoux commented 9 years ago

Hi again @sodoku :) I think I'll remove bootstrap as a choice on the next version. It too much overhead between LESS/Sass/CSS integration. The user will have the freedom to install wathever (s)he wants. As for pure CSS, I think it's quite hard to handle automatically as there is a notion of order between the .css files (which isn't a problem with sass or less).

jgoux commented 9 years ago

I have removed bootstrap in the dev branch, the user will have to add it with bower instead.