search

jgpacheco / ngx-translate-cache

MIT License
14 stars 12 forks source link

Just a question #2

Open stherrienaspnet opened 6 years ago

stherrienaspnet commented 6 years ago

Can ngx-translate-cache work with rxjs 6.x?

Thanks

jgpacheco commented 6 years ago

@stherrienaspnet I haven't tested, but I don't see why not. If you find some issue please post it here.

stherrienaspnet commented 6 years ago

Thanks you very much! I will let you know :)

stherrienaspnet commented 6 years ago

Hello I have a made a migration from angular 5 to 7 and I'm getting these warning: ngx-translate-cache@0.1.0 requires a peer of @angular/core@^4.0.0 but none is installed. You must install peer dependencies yourself. npm WARN ngx-translate-cache@0.1.0 requires a peer of rxjs@^5.1.0 but none is installed. You must install peer dependencies yourself. npm WARN ngx-translate-cache@0.1.0 requires a peer of @ngx-translate/core@^8.0.0 but none is installed. You must install peer dependencies yourself.

Do you think it is possible to update the some dependencies conditions? (^ by >= ) It all your tests still pass.

Thanks :)

jgpacheco commented 5 years ago

@stherrienaspnet PRs are welcome! I will try to do it this weekend if you don't have the time. ;)