jgpacker / osm-smart-menu

An OpenStreetMap webextension for Firefox and Chrome
GNU General Public License v3.0
56 stars 12 forks source link

Add official map services from Germany (where possible) #23

Open daganzdaanda opened 4 years ago

daganzdaanda commented 4 years ago

Hi, thanks for this add-on, it looks very helpful!

I thought the German community might be happy about quick switches to and from the official map services of the German states. So I looked at the 16 "Geoportals" linked here: https://gis-netzwerk.com/gis/geoportal-deutschland As far as I can see, only Bavaria and Lower Saxony offer a website where you can get the coordinates from the URL:

Bavaria looks like https://geoportal.bayern.de/bayernatlas/?lang=de&catalogNodes=11,122&bgLayer=atkis&E=675028.06&N=5341598.86&zoom=6 The list of variables can be much longer, depending on the active views.

Niedersachsen: https://www.geobasis.niedersachsen.de/?x=9.7437&y=52.3822&z=8

Could you add those two?

I'm not so sure if the "Web Atlas DE" is a helpul resource for mappers outside of those two states. It covers all of Germany, but only with one basic style, no aerial imagery. Also it will not update the URL automatically, but you can get a permalink like this: https://sg.geodatenzentrum.de/web_bkg_webmap/applications/webatlasde/webatlasde.html?zoom=8&lat=5404410.48005&lon=516184.66601&layers=B0T

jgpacker commented 4 years ago

Hello! At this moment, I think this extension should not have local websites by default (to avoid information overload for new users), but I'm happy to create ways users can add other websites they like!

As of version 0.10.4, these websites can already be added:

Check the feature announcement: https://www.openstreetmap.org/user/jgpacker/diary/393442

jgpacker commented 4 years ago

Another possibility is to add these websites to the default list if and only if the user has german (de-DE) configured as a system language. However I am happier implementing some strategy where each local community can curate links by themselves (increasing user autonomy).

jgpacker commented 4 years ago

The other link you listed is not supported right now: https://geoportal.bayern.de/bayernatlas/?lang=de&catalogNodes=11,122&bgLayer=atkis&E=675028.06&N=5341598.86&zoom=6

In the future, there should be a way to provide an URL template such as https://geoportal.bayern.de/bayernatlas/?E={longitude}&N={latitude}&zoom={zoom} to add such a link to your list.

jgpacker commented 4 years ago

I just added the possibility of URL templates! However it looks like the parameters E and N used in "Web Atlas DE" are not compatible with the common latitude and longitude parameters :-( For example, https://geoportal.bayern.de/bayernatlas/?E=670944.04&N=5405283.56&zoom=11 seems to be equivalent to https://www.openstreetmap.org/#map=16/48.7778/11.3248

Do you perhaps understand why?

tordanik commented 4 years ago

These maps appear to be using a different coordinate system (presumably UTM coordinates) instead of degrees longitude/latitude. That's a somewhat common sight with government institutions in Germany.

jgpacker commented 4 years ago

Thanks @tordanik ! I created #55 to track this feature.

jgpacker commented 4 years ago

In the future, it might be possible for users to import list of links. I recommend creating list of suggested links e.g. by listing them in an OpenStreetMap Wiki page.

yrtimiD commented 2 years ago

@jgpacker , will you accept PR which adds some local maps? To not scary new users you can organize maps by collapsible category/country/tag like your main competitor OpenSwitchMaps did. IMHO, this extension has a big future, but local sites support is a main deal breaker.

jgpacker commented 2 years ago

@yrtimiD Right now I'm avoiding the addition of new default / built-in URLs into this extension. I want to make things easier for users, but I'm having a major issue with the Google Chrome store, which is rejecting new updates because it's classifying this extension as "Spam" (I'm not sure how to solve this and have stagnated).

Since I still have hope the Google Chrome issue can be solved, I'm avoiding new built-in URLs, but I am accepting contributions to features (such as #55). I'm not sure I will be able to publish it to Google Chrome, but at least Firefox will have the new feature.

Bibi56 commented 2 years ago

In the future, it might be possible for users to import list of links. I recommend creating list of suggested links e.g. by listing them in an OpenStreetMap Wiki page.

I've started to create a list of list, see https://wiki.openstreetmap.org/wiki/Talk:OSM_Smart_Menu#Advanced_method_to_add_new_links. Feedback and improvements welcome.

@jgpacker, after adding such a link, we can rename or delete it but not see the template anymore or I don't know how, should I create a ticket for that?