search

jgpacker / osm-smart-menu

An OpenStreetMap webextension for Firefox and Chrome
GNU General Public License v3.0
56 stars 12 forks source link

Not clear what sites to expect the app to work on #27

Open jidanni opened 4 years ago

jidanni commented 4 years ago

The app could even work when browsing e.g., https://www.google.com.tw/maps/search/24.18169,120.86617 by simply grabbing the coordinates from the current URL.

But I am not sure you want to make the app work when browsing non-OSM related sites.

Indeed reading https://chrome.google.com/webstore/detail/osm-smart-menu/icipmdhgbkejfideagkhdebiaeohfijk one might one might even think the app can.

However the app works when browsing https://www.opentopomap.org/ but not https://openinframap.org/ , so maybe it only works on sites within the list of sites in the drop down menu. All this isn't clear from that webstore detail page.

It should also be mentioned on a help page within the app.

jgpacker commented 4 years ago

Can you check which version you are using? OpenInfraMap works for me (but only when the map parameters appear in the URL, because it doesn't have a permalink)

jgpacker commented 4 years ago

My current plan is: (1) automatically detect and allow addition of most common/recurring patterns; and (2) allow users to specify an URL template for unusual cases (not available yet).

I'm adding https://www.google.com.tw/maps/search/24.18169,120.86617 to my annotations (so I can figure out the best strategy to extract these parameters)

jgpacker commented 4 years ago

I agree that a help page is needed to clarify some subtle features. I'm deciding between adding one inside the extension or inside the OpenStreetMap Wiki.

Right now, I'm just announcing new features in my OSM diary: https://www.openstreetmap.org/user/jgpacker/diary

jidanni commented 4 years ago

Well most users will be looking within the running app itself for any help sheets or help links.

Make sure any error messages don't just say

ERROR: Current site was not recognized as compatible with OpenStreetMap. If this is unexpected, you can report it in github.com/jgpacker/osm-smart-menu/.

but also give tons of reasons. E.g., when used upon this GitHub page it should say

There aren't even any coordinates I can find within the URL bar. Are you sure this is a mapping site?

And for that OpenInfraMap case:

I know about this site, but there aren't any coordinates I can find within the URL bar. Move the view to start generating some first please.

jidanni commented 4 years ago

Actually https://www.google.com.tw/maps/search/24.18169,120.86617 turns into

https://www.google.com.tw/maps/place/24%C2%B010'54.1%22N+120%C2%B051'58.2%22E/@24.18169,120.86617,17z/data=!3m1!4b1!4m5!3m4!1s0x0:0x0!8m2!3d24.18169!4d120.86617

when you browse it. But at least one can still dig out 24.18169,120.86617,17z .

jgpacker commented 4 years ago

And for that OpenInfraMap case:

I know about this site, but there aren't any coordinates I can find within the URL bar. Move the view to start generating some first please.

I actually already have this kind of error message, but it only works for websites currently listed in the extension (and OpenInfraMaps is not listed by default). See this kind of message in bing: https://www.bing.com/maps (invoking the extension without changing the maps).

One thing that makes it hard to give correct advice to the user are special cases that do not have parameters in the URL and also no permalink (I created today issues #30 and #31 to track this).

I agree with the spirit of your suggestions. I will review the error messages to make them clearer.

jgpacker commented 4 years ago

About the Google URLs: I agree these parameters should be recognized. I will implement this soon.

jidanni commented 4 years ago

I actually already have this kind of error message, but it only works for websites currently listed in the extension (and OpenInfraMaps is not listed by default). See this kind of message in bing: https://www.bing.com/maps (invoking the extension without changing the maps).

Actually you will need to have the error message mention both

  1. Know about site: yes/no
  2. Know about URL format: yes/no

for every site that causes an error. Else people won't know that the program is that smart, unless one day they trigger it on that Bing URL, etc.

Bibi56 commented 4 years ago

Another extension with similar purpose is: https://github.com/tankaru/OpenSwitchMaps

The extension analyzes other data sources, enabling to jump into the OSM world ;-).

jgpacker commented 4 years ago

@Bibi56 While I respect the results and hard work from OpenSwitchMaps, I believe there are some technical advantages in OSM Smart Menu, such as: (1) it works well in Firefox for Android; (2) permalink detection; (3) interface available in other languages; (4) requires less security permissions; (5) automatically recognizes a set of common URL patterns and allow users to add them to the list independently.

jgpacker commented 4 years ago

I will be tracking the improvement for Google Maps at #53

Bibi56 commented 3 years ago

I've seen you made an (excellent) wiki page. I guess most of @jidanni request are solved this way. You should make a link to the wiki in the Advanced Option Creation. I've some ideas to improve that further let me know if you would like a ticket on the subject.

jgpacker commented 3 years ago

@Bibi56 I agree! I will add a link to the wiki in the configuration page.

I do want feedback on how to improve the wiki page :-)