jgpacker / osm-smart-menu

An OpenStreetMap webextension for Firefox and Chrome
GNU General Public License v3.0
56 stars 12 forks source link

Osmose parameters not recognized #83

Closed Bibi56 closed 3 years ago

Bibi56 commented 4 years ago

http://osmose.openstreetmap.fr/en/map/#item=7130&zoom=18&lat=48.439383&lon=-4.416006&level=1%2C2%2C3&tags=&fixable= is not recognized but it has the 3 normal parameters: zoom=18&lat=48.439383&lon=-4.416006 I guess you're using a regular expression instead of a library to extract parameters of the query. BTW I don't understand why the link (found on an Osmose page) is not http://osmose.openstreetmap.fr/en/map/#item=7130?zoom=18&lat=48.439383&lon=-4.416006&level=1%2C2%2C3&tags=&fixable= (first parameter after a ? not after a &). Should I rather create a ticket on Osmose front-end? As the URL is accepted by a browser, probably not.

Anyway, usually OSM Smart Menu is a great extension ;-).

jgpacker commented 3 years ago

Thanks for the bug report! The fix is available at version 0.15.10.

Indeed regular expression is being used in the default links list. I have developed better techniques for the automatically-recognized URL patterns, but unfortunately I have not applied these techniques for the default links list yet.

BTW I don't understand why the link (found on an Osmose page) is not http://osmose.openstreetmap.fr/en/map/#item=7130?zoom=18&lat=48.439383&lon=-4.416006&level=1%2C2%2C3&tags=&fixable= (first parameter after a ? not after a &).

Basically, ? must be before #, and the browsers behave differently for text after #. I don't think it's an official standard to put parameters after #, but I have seen a few other websites doing this.