jgpacker / osm-smart-menu

An OpenStreetMap webextension for Firefox and Chrome
GNU General Public License v3.0
56 stars 12 forks source link

Add link to OSM iD editor #92

Closed jidanni closed 3 years ago

jidanni commented 3 years ago

Add "OSM iD editor" to X0 That way we could directly get to e.g. https://www.openstreetmap.org/edit#map=17/24.17148/120.67252 in one click!

Yes, there are even preview editions of iD. But let's add the basic one at least. Thanks.

Cj-Malone commented 3 years ago

Seems to have been added in https://github.com/jgpacker/osm-smart-menu/commit/a74737fa152620af692afa8d82842742ffc00296 but I think it should be renamed, as the link opens in peoples default editor, so for me thats JOSM.

jgpacker commented 3 years ago

@Cj-Malone Thanks for the catch! I will fix it to point to iD

Cj-Malone commented 3 years ago

Well, I'd prefer it to keep the current URL, that way I can use it too. Maybe just change the label?

jgpacker commented 3 years ago

I'm afraid a "default editor" option can be a little confusing.

I recommend adding a JOSM option with https://www.openstreetmap.org/edit?editor=remote#map={zoom}/{latitude}/{longitude} in the advanced configuration section (see here).

Cj-Malone commented 3 years ago

I don't really understand why editor is in the URL, osm.org correctly redirects me to JOSM (my preferred editor) with or without editor=id.

Anyway I've just renamed the iD one to "Edit" and I'm happy with that, it opens JOSM.

jgpacker commented 3 years ago

Accessing /edit?editor=id will point to iD editor even when I set "JOSM or Merkaartor" as the default editor in my user settings, so I'm going to close this issue for now.

I have added the JOSM's URL Template in the wiki page so more advanced users can find it.