search

jgraham / rust_mozprofile

Rust lirary for managing mozilla profiles
Mozilla Public License 2.0
3 stars 2 forks source link

mozprofile 0.2 release contains Emacs backup file #1

Open andreastt opened 7 years ago

andreastt commented 7 years ago

The mozprofile 0.2 crate on crates.io contains an Emacs backup file, src/prefdata.rs~. This causes problems when importing geckodriver to mozilla-central (https://bugzilla.mozilla.org/show_bug.cgi?id=1340637) because it has .gitignore/.hgignore files that don’t let you add this file.

This again causes problems when the patches to build geckodriver in m-c run on the build slaves because cargo fails the integrity check of the crate package, as can be seen in https://treeherder.mozilla.org/logviewer.html#?job_id=78421179&repo=try&lineNumber=5064.

andreastt commented 7 years ago

@jgraham I would patch this issue myself, but rust_mozprofile is on your private account.

andreastt commented 7 years ago

I was able to work around this issue by git add --force third_party/rust/mozprofile/src/*.rs~.

luser commented 7 years ago

I verified that the backup files are in the published crate:

$ wget https://crates-io.s3-us-west-1.amazonaws.com/crates/mozprofile/mozprofile-0.2.0.crate
$ tar xzf mozprofile-0.2.0.crate
$ find mozprofile-0.2.0 -type f
mozprofile-0.2.0/LICENSE
mozprofile-0.2.0/Cargo.lock~
mozprofile-0.2.0/Cargo.toml
mozprofile-0.2.0/.gitignore
mozprofile-0.2.0/Cargo.toml~
mozprofile-0.2.0/src/#tempdir.rs#
mozprofile-0.2.0/src/prefdata.rs~
mozprofile-0.2.0/src/profile.rs
mozprofile-0.2.0/src/prefdata.rs
mozprofile-0.2.0/src/lib.rs
mozprofile-0.2.0/src/preferences.rs~
mozprofile-0.2.0/src/lib.rs~
mozprofile-0.2.0/src/prefreader.rs
mozprofile-0.2.0/src/preferences.rs
mozprofile-0.2.0/src/prefreader.rs~
mozprofile-0.2.0/src/profile.rs~

I think cargo publish will honor .gitignore, but this repo doesn't list *~ in its .gitignore.