search

jgraichen / restify

Restify is a experimental, parallel and pipelined Hypermedia API client
GNU Lesser General Public License v3.0
8 stars 2 forks source link

Extract a few methods #10

Closed franzliedke closed 7 years ago

franzliedke commented 7 years ago

This extracts some methods in the new pool class.

My goals: smaller methods and revealing names to make the logic a little easier to understand.

This should be a safe refactoring (i.e. no change in behavior), except for one additional log message which I will explain inline.

As a nice side effect, this also gets rid of disabled Rubocop warnings, as we are now safely in bounds.

franzliedke commented 7 years ago

@jgraichen I just added some comments and changed a few variable names where I felt that made them more revealing. Hope you agree. :)

franzliedke commented 7 years ago

Oh, and some docblocks for public methods.

jgraichen commented 7 years ago

:+1: Impressive work!