search

jgraichen / restify

Restify is a experimental, parallel and pipelined Hypermedia API client
GNU Lesser General Public License v3.0
8 stars 2 forks source link

Fix hierarchy of exception classes #30

Closed franzliedke closed 4 years ago

franzliedke commented 4 years ago

The GatewayError class was recently introduced (in 3053cf8) to group together status codes 502, 503 and 504.

It broke the previous expectation of all 5xx status codes raising an instance of ServerError (or one of its children). This is restored with this commit.

codecov[bot] commented 4 years ago

Codecov Report

Merging #30 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   91.22%   91.22%           
=======================================
  Files          22       22           
  Lines         832      832           
=======================================
  Hits          759      759           
  Misses         73       73
Impacted Files Coverage Δ
lib/restify/error.rb 87.75% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3be3308...17633a8. Read the comment docs.