search

jgraichen / restify

Restify is a experimental, parallel and pipelined Hypermedia API client
GNU Lesser General Public License v3.0
8 stars 2 forks source link

Replace request stubs with real stub server #43

Closed jgraichen closed 3 years ago

jgraichen commented 3 years ago

This CL replaces the inline webmock stubs with real requests agains a stub server. The stub server still uses webmock for matching incoming requests.

This should make testing much more reliable and realistic especially for eventmachine-based adapters. Webmock previously patched all HTTP client adapters but that introduced subtile behavior changes with concurrency or scheduling of threads or callbacks. Using the stub server and real communication the adapter behave much more like in production including possible concurrent requests or expected threading behavior.

codecov[bot] commented 3 years ago

Codecov Report

Merging #43 (914150d) into master (576a134) will increase coverage by 0.15%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   95.31%   95.47%   +0.15%     
==========================================
  Files          20       20              
  Lines         641      641              
==========================================
+ Hits          611      612       +1     
+ Misses         30       29       -1
Impacted Files Coverage Δ
lib/restify/adapter/typhoeus.rb 95.94% <0.00%> (+1.35%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 576a134...914150d. Read the comment docs.