Get base plink into agents at planning/config time

[jgraley]

The keyer plink is the base. Configure the agents with keyer and residuals. Then:

• [x] Don't pass anything in to NLQ for the base - use the configured base plink instead.
  • XLink base_xlink = required_links->at(base_plink);
• [x] Configure should create a set of "base and child plinks"
• [x] Same with regeneration query (RQ) (for consistency; not needed by CSP)
• [x] Do #321
• [x] Same with coupling query (CQ) more like NLQ i.e. with a required_links that it indexes with the configured residuals.
• [x] Colocated agent should use configured base and child plinks directly
• [x] See what else can be stiffened on the back of this

[jgraley]

Stiffening for the CQ is quite hard. The problem seems to be determining at planning time what the keyer/residual pattern links should be. These need to (in principle) match the keyings that occur in run-time in the make-it-up-as-you-go-along algorithm. Did a quick analysis (08e903aa):

Defined 6 places in the code where keys are added to a CouplingKeysMap, and then printed these out in AndRuleEngine::CompareCoupling():

• KEY_PRODUCER_6 in AndRuleEngine::CompareLinks() for links in plan.coupling_keyer_links (which is non-trivial keyers)
  • AndRuleEngine::CompareCoupling() sees a fair number of hits; to my_coupling_keys
• KEY_PRODUCER_1 also in AndRuleEngine::CompareLinks() via AndRuleEngine::RecordLink() subject to conditions: not root plink, not residual, not MMAX. To external_keys
  • In spite of tight conditions, AndRuleEngine::CompareCoupling() sees lots of hits
• KEY_PRODUCER_2 in AndRuleEngine::RegenerationPassAgent() for free abnormal links. To external_keys
  • But not seen in AndRuleEngine::CompareLinks()
  • Comment says // Replace needs these keys
• KEY_PRODUCER_3 in AndRuleEngine::Compare() keying the root link if not MMAX . To external_keys
  • But not seen in AndRuleEngine::CompareLinks() Removed the need to key at this location by rotating the DQ recursion
• KEY_PRODUCER_4 in AndRuleEngine::GetNextCSPSolution()
  • But not seen in AndRuleEngine::CompareLinks()
  • this is a CSP solver only path
• KEY_PRODUCER_5 in SCREngine::GatherCouplings() for when an agent has self-keyed but not found in coupling_keys
  • AndRuleEngine::CompareCoupling() sees a fair number of hits and these correspond to ASSERT fails due base_plink NULL when trying to stiffen
  • First failure is AddStateLabelVar around the InstanceIdentifier state
  • Still happens even if SCREngine::Plan::ConfigureAgents() configures all the REPLACE_ONLY agents meta-data is now retained though this operation
• KEY_PRODUCER_7 is any of the four Builder agents in inferno_agents.cpp in BuildReplaceImpl()To agent local

[jgraley]

Consumers:

• CONSUMER_1 CC in DC recurse from my_coupling_keys
• CONSUMER_6 CC in DC recurse from master_keys
• CONSUMER_7 CC in trivial problem, from master_keys removed the need for this by rotating DQ recurse and generally fixing things that were wrong.
• CONSUMER_3 replace: stuff node getting terminus from agent local
• CONSUMER_5 replace: BuildReplace getting coupled X for replace, from agent local

[jgraley]

Better analysis processed.txt

Strings on right are [producer trace prefix]->[consumer trace prefix]. Trace prefixes are stripped of common prefix. Run on all sctest*

[jgraley]

Done