jgraley / inferno-cpp2v

2 stars 0 forks source link

Sort out horrible function #413

Closed jgraley closed 2 years ago

jgraley commented 2 years ago

DefaultMMAXAgent::RunNormalLinkedQueryImpl() is horrible; sort it out. I think it's trying to do strict MMAX, but strict MMAX should be symmetrical across { keyer (=base) plink, the normal plinks }.

jgraley commented 2 years ago

DisjunctionAgent was going through DefaultMMAXAgent which meant I couldn't enforce the all-or-nothing pattern on MMAX. But that's wrong - disjunction is obviously not a default MMAX algorithm. Redid the latter's NLQ() and DQ(), with NLQ explicitly handling the keyer==MMAX case. Then tidied up DefaultMMAXAgent as required.