search

jgraley / inferno-cpp2v

2 stars 0 forks source link

Symbolic query: local expressions #474

Closed jgraley closed 2 years ago

jgraley commented 2 years ago

For both of these, use a new "local Expression node" approach:

Use for:

This could be said to be not much better than the lambdas. But it is better.

Then: really take a hatchet to all the support for NLQs and fallbacks in common and intermediate agent classes.

jgraley commented 2 years ago

Which classes to derive from:

IdentifierByName and GreenGrass

Agent should derive from PreRestrictionAgent Expression should drive from SymbolToBooleanExpression

Star

Agent should derive from AgentCommon Expression should derive from KindOfOperator

TODO find out what Star does about MMAX atm

jgraley commented 2 years ago

What StarAgent does about MMAX

Nothing.

AgentCommon::RunRegenerationQuery() filters out MMAX keyer before calling StandardAgent::RunRegenerationQueryImpl(), which doesn't do anything with MMAX. Thus Star will never get an MMAX or a SubContainer that includes an MMAX.