jgraph / drawio-desktop

Official electron build of draw.io
https://www.diagrams.net
Apache License 2.0
50.04k stars 4.97k forks source link

OS-level erros during printing are ignored #1837

Open FarSeeing opened 1 month ago

FarSeeing commented 1 month ago

Preflight Checklist

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.

Describe the bug If any error (like no printer found) happens during at attempt to print a file it just gets silenced:

contents.print(pdfOptions, (success, errorType) => 
{
    //Consider all as success
    event.reply('export-success', {});
});

Probably it's redundant to handle each error but just displaying a message like "something went wrong" would be enough.

Expected behavior An error message gets shown if anything happens.

draw.io version (In the Help->About menu of the draw.io editor):